[vlc-devel] [PATCH] contrib: use the pkg info from our contribs before the system ones

[Steve Lhomme]

On Wed, Oct 26, 2016 at 5:37 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> Le keskiviikkona 26. lokakuuta 2016, 17.32.27 EEST Steve Lhomme a écrit :
>> When a package is forced to be built rather than using the system one, we
>> want to use the contrib one when building depending packages.
>
> Perhaps but that´s not what this patch does. The system path is not passed by
> environment variables.
>
> What this patch does is deprioritize a *manually* set pkg-config directory. I
> do not see any reasons to do that.

Not sure how it works on other systems, but in Msys2 the default is
"/mingw32/lib/pkgconfig:/mingw32/share/pkgconfig"
And I do see it in all the contribs I build.

What I want is
PKG_CONFIG_PATH=/c/Users/robUx4/Documents/Programs/Videolabs/work/contrib/i686-w64-mingw32/lib/pkgconfig:/mingw32/lib/pkgconfig:/mingw32/share/pkgconfig

and not

PKG_CONFIG_PATH=/mingw32/lib/pkgconfig:/mingw32/share/pkgconfig:/c/Users/robUx4/Documents/Programs/Videolabs/work/contrib/i686-w64-mingw32/lib/pkgconfig

>> ---
>>  contrib/src/main.mak | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/contrib/src/main.mak b/contrib/src/main.mak
>> index 9042227..d8f1d37 100644
>> --- a/contrib/src/main.mak
>> +++ b/contrib/src/main.mak
>> @@ -216,7 +216,7 @@ PKG_CONFIG_PATH := /usr/share/pkgconfig
>>  PKG_CONFIG_LIBDIR := /usr/$(HOST)/lib/pkgconfig
>>  export PKG_CONFIG_LIBDIR
>>  endif
>> -PKG_CONFIG_PATH := $(PKG_CONFIG_PATH):$(PREFIX)/lib/pkgconfig
>> +PKG_CONFIG_PATH := $(PREFIX)/lib/pkgconfig:$(PKG_CONFIG_PATH)
>>  export PKG_CONFIG_PATH
>>
>>  ifndef GIT
>
>
> --
> Rémi Denis-Courmont
> Nonsponsored VLC developer
> http://www.remlab.net/CV.pdf
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel