[vlc-devel] [PATCH] contrib: use the pkg info from our contribs before the system ones

[Rémi Denis-Courmont]

Le keskiviikkona 26. lokakuuta 2016, 17.50.07 EEST Steve Lhomme a écrit :
> On Wed, Oct 26, 2016 at 5:37 PM, Rémi Denis-Courmont <remi at remlab.net> 
wrote:
> > Le keskiviikkona 26. lokakuuta 2016, 17.32.27 EEST Steve Lhomme a écrit :
> >> When a package is forced to be built rather than using the system one, we
> >> want to use the contrib one when building depending packages.
> > 
> > Perhaps but that´s not what this patch does. The system path is not passed
> > by environment variables.
> > 
> > What this patch does is deprioritize a *manually* set pkg-config
> > directory. I do not see any reasons to do that.
> 
> Not sure how it works on other systems, but in Msys2 the default is
> "/mingw32/lib/pkgconfig:/mingw32/share/pkgconfig"
> And I do see it in all the contribs I build.

The default value is that the variable is not defined, which makes pkg-config 
look in predefined locations only.

The point of the code is, as I just wrote already, to add contribs after the 
user-defined libraries. The patch looks counter-sensical to me.

-- 
Rémi Denis-Courmont
Nonsponsored VLC developer
http://www.remlab.net/CV.pdf