[vlc-devel] [PATCH] modules/bank: prevent null-pointer dereference in AllocatePluginFile

Filip Roséen filip at atch.se
Fri Oct 28 09:00:46 CEST 2016

Hi Filip (aka. myself),

Once again your forgot to honor the *coding-style* of the file which the patch
applies to, as a helpful reminder what follows is an ascii-fish (that will eat
you if you continue to forgot what has been mentioned).

    [bug]     /"*._         _
          .-*'`    `*-.._.-'/
        < * ))     ,       ( 
    src: http://www.ascii-code.com/ascii-art/animals/fish.php

On 2016-10-28 08:54, Filip Roséen wrote:

> Given that module_InitDynamic can fail and return a NULL pointer to
> signal the error, we cannot unconditionally set data-members of the
> referred to vlc_plugin_t.
> These changes fixes the issue by introducing an explicit branch
> related to initialization.
> ---
>  src/modules/bank.c | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
>  ...

Attached to this email is a patch where the original *coding-style* is

Best Regards,\
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20161028/268f471a/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-modules-bank-prevent-null-pointer-dereference-in-All.patch
Type: text/x-diff
Size: 1289 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20161028/268f471a/attachment.patch>

More information about the vlc-devel mailing list