[vlc-devel] [PATCH 1/4] test/url: move test for empty port-specification

[Filip Roséen]

Hi Rémi,

On 2016-10-28 15:15, Rémi Denis-Courmont wrote:

> Le perjantaina 28. lokakuuta 2016, 10.49.44 EEST Filip Roséen a écrit :
> > According to RFC3986, the port specifier does not have to contain
> > digits following the colon. This means that "http://example.com:" is a
> > valid URI, and that the relevant test should not be within the
> > "Invalid URIs"-group.
> 
> You need to fix vlc_UrlParse() too. It returns an error if  'end == next'.

Yeah, as *tguillem* said I should have used another order for the
patches - sorry about that!

 - Should I rebase and resend them in the correct order? Basically
   `4/4` should be `#1`, and the other patches should follow that one. 
  
Best Regards,\
Filip

> 
> > ---
> >  src/test/url.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/src/test/url.c b/src/test/url.c
> > index 2ed99d5..ffb073c 100644
> > --- a/src/test/url.c
> > +++ b/src/test/url.c
> > @@ -268,6 +268,8 @@ int main (void)
> >                     "/", NULL);
> >      test_url_parse("http://[2001:db8::1]", "http", NULL, NULL,
> > "2001:db8::1", 0, NULL, NULL);
> > +    test_url_parse("http://example.com:", "http", NULL, NULL,
> > "example.com", 0, +                    NULL, NULL);
> >      test_url_parse("protocol://john:doe@1.2.3.4:567", "protocol", "john",
> > "doe", "1.2.3.4", 567, NULL, NULL); test_url_parse("http://a.b/?opt=val",
> > "http", NULL, NULL, "a.b", 0, "/", "opt=val");
> > test_url_parse("p://u:p@host:123/a/b/c?o=v", "p", "u", "p", "host", 123,
> > "/a/b/c", "o=v"); @@ -300,8 +302,6 @@ int main (void)
> >      /* Invalid URIs */
> >      test_url_parse("p://G a r b a g e", "p", NULL, NULL, NULL, 0, NULL,
> > NULL); test_url_parse("p://h/G a r b a g e", "p", NULL, NULL, "h", 0, NULL,
> > NULL); -    test_url_parse("http://example.com:", "http", NULL, NULL,
> > "example.com", 0, -                    NULL, NULL);
> >      test_url_parse("http://example.com:123xyz", "http", NULL, NULL,
> >                     "example.com", 123, NULL, NULL);
> 
> 
> -- 
> Rémi Denis-Courmont
> Nonsponsored VLC developer
> http://www.remlab.net/CV.pdf
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20161028/46a1338c/attachment.html>