[vlc-devel] [PATCH 07/10] avcodec: remove unnecessary condition

[Rémi Denis-Courmont]

Le dimanche 4 septembre 2016, 15:30:11 ileoo at videolan.org a écrit :
> From: Ilkka Ollakka <ileoo at videolan.org>
> 
> condition makes no sense in here, as skipframes is setted already

Nit: set

> unconditionally at the start of the block.
> ---
>  modules/codec/avcodec/video.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/modules/codec/avcodec/video.c b/modules/codec/avcodec/video.c
> index 83e6b0b..96d65a1 100644
> --- a/modules/codec/avcodec/video.c
> +++ b/modules/codec/avcodec/video.c
> @@ -769,11 +769,6 @@ static picture_t *DecodeVideo( decoder_t *p_dec,
> block_t **pp_block ) msg_Warn( p_dec, "More than 11 late frames, dropping
> frame" ); return NULL;
>          }
> -
> -        if( p_context->width <= 0 || p_context->height <= 0 )
> -        {
> -            p_context->skip_frame = p_sys->i_skip_frame;
> -        }
>          else if( !b_need_output_picture )

Stray 'else'?

>          {
>              p_context->skip_frame = __MAX( p_context->skip_frame,

-- 
Rémi Denis-Courmont
http://www.remlab.net/