[vlc-devel] [PATCH 07/10] avcodec: remove unnecessary condition

[Ilkka Ollakka]

On Sun, Sep 04, 2016 at 05:33:39PM +0300, Rémi Denis-Courmont wrote:
> Le dimanche 4 septembre 2016, 15:30:11 ileoo at videolan.org a écrit :
> > From: Ilkka Ollakka <ileoo at videolan.org>

> > condition makes no sense in here, as skipframes is setted already

> Nit: set

Fixed

> > unconditionally at the start of the block.
> > -        if( p_context->width <= 0 || p_context->height <= 0 )
> > -        {
> > -            p_context->skip_frame = p_sys->i_skip_frame;
> > -        }
> >          else if( !b_need_output_picture )

> Stray 'else'?

Yes, next patch fixed it. I fixed the patches to be more coherent on
that aspect.

> >          {
> >              p_context->skip_frame = __MAX( p_context->skip_frame,
-- 
Ilkka Ollakka
Randal can write one-liners again.  Everyone is happy, and peace spreads
over the whole Earth.
		-- Larry Wall in <199705101952.MAA00756 at wall.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Digital signature
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20160905/fb892298/attachment.sig>