[vlc-devel] [PATCH 2/3] vpx: Decode additional profiles and high bit depth formats

Jean-Baptiste Kempf jb at videolan.org
Mon Sep 26 10:03:43 CEST 2016


On 25 Sep, Vittorio Giovara wrote :
> On Sun, Sep 25, 2016 at 11:59 AM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
> > On 25 Sep, Vittorio Giovara wrote :
> >> +    { VLC_CODEC_I420, VPX_IMG_FMT_I420, 0, 8, 0 },
> >> +    { VLC_CODEC_I422, VPX_IMG_FMT_I422, 0, 8, 0 },
> >> +    { VLC_CODEC_I444, VPX_IMG_FMT_I444, 0, 8, 0 },
> >> +    { VLC_CODEC_I440, VPX_IMG_FMT_I440, 0, 8, 0 },
> >> +
> >> +    { VLC_CODEC_J420, VPX_IMG_FMT_I420, 1, 8, 0 },
> >> +    { VLC_CODEC_J422, VPX_IMG_FMT_I422, 1, 8, 0 },
> >> +    { VLC_CODEC_J444, VPX_IMG_FMT_I444, 1, 8, 0 },
> >> +    { VLC_CODEC_J440, VPX_IMG_FMT_I440, 1, 8, 0 },
> >> +
> >
> > Those 4 do not make sense, at all.
> 
> Should I just ditch those and correctly set the fullrange flag?

Yes.

> >> +static vlc_fourcc_t FindVlcChroma( struct vpx_image *img, vpx_codec_caps_t codec_caps )
> >> +{
> >> +    int hack = (img->fmt & VPX_IMG_FMT_I444) && (img->cs == VPX_CS_SRGB);
> >
> > ??
> 
> They use one of the colorspace values to signal planar rgb, see
> - http://git.videolan.org/?p=ffmpeg.git;a=blob;f=libavcodec/libvpxenc.c;h=2db87f7f2a27374a37609033e083c1a92c30a828;hb=HEAD#l300
> - http://git.videolan.org/?p=ffmpeg.git;a=blob;f=libavcodec/libvpxdec.c;h=5204c993cd7de6b1dc7fd7c7f8173024af0e858a;hb=HEAD#l109

This is beyond ugly.

With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device


More information about the vlc-devel mailing list