[vlc-devel] [PATCH 2/3] vpx: Decode additional profiles and high bit depth formats

Vittorio Giovara vittorio.giovara at gmail.com
Mon Sep 26 17:41:55 CEST 2016


On Mon, Sep 26, 2016 at 4:03 AM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
>> >> +static vlc_fourcc_t FindVlcChroma( struct vpx_image *img, vpx_codec_caps_t codec_caps )
>> >> +{
>> >> +    int hack = (img->fmt & VPX_IMG_FMT_I444) && (img->cs == VPX_CS_SRGB);
>> >
>> > ??
>>
>> They use one of the colorspace values to signal planar rgb, see
>> - http://git.videolan.org/?p=ffmpeg.git;a=blob;f=libavcodec/libvpxenc.c;h=2db87f7f2a27374a37609033e083c1a92c30a828;hb=HEAD#l300
>> - http://git.videolan.org/?p=ffmpeg.git;a=blob;f=libavcodec/libvpxdec.c;h=5204c993cd7de6b1dc7fd7c7f8173024af0e858a;hb=HEAD#l109
>
> This is beyond ugly.

Indeed ^^
Hence the variable name.
-- 
Vittorio


More information about the vlc-devel mailing list