[vlc-devel] [RFC PATCH 1/2] libvlc: media: remove usage of ssize_t

[Rémi Denis-Courmont]

Le mardi 27 septembre 2016, 13:49:02 Thomas Guillem a écrit :
> On Fri, Jul 22, 2016, at 14:45, Thomas Guillem wrote:
> > On Fri, Jul 22, 2016, at 14:35, Rémi Denis-Courmont wrote:
> > > Nack.
> > > 
> > > int can be smaller than (s)size_t, and typically is on 64-bits
> > > platforms.
> > 
> > We both agree on that. Here, int is not used to return the size read.
> 
> Ping (patch can be found here:
> https://github.com/tguillem/vlc/commit/884d1974dbb5f4da61411c2aa6cff8e257b70
> bb6)

I don't agree. I dislike the API change; it's against usual I/O conventions of 
C, of POSIX, VLC and countless others. And even if this is not part of the 
stable ABI yet, it will break existing eager users code in confusing way.

-- 
Rémi Denis-Courmont
http://www.remlab.net/