[vlc-devel] [vlc-commits] configure.ac: Use AC_PATH_PROGS for luac
remi at remlab.net
Thu Sep 29 03:27:06 CEST 2016
Le mercredi 28 septembre 2016, 14:18:44 Steve Lhomme a écrit :
> On Wed, Aug 3, 2016 at 4:56 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> > Le 2016-08-03 15:52, Rafaël Carré a écrit :
> >> On 08/03/2016 03:49 PM, Hugo Beauzée-Luyssen wrote:
> >>> On 08/03/2016 03:46 PM, Rafaël Carré wrote:
> >>>> On 08/03/2016 03:43 PM, Hugo Beauzée-Luyssen wrote:
> >>>>> I have no problem reverting this patch, but I'd like to have an
> >>>>> alternative solution which doesn't involve installing luac system wide
> >>>>> before compiling.
> >>>> export PATH=$vlc/contrib/`gcc -dumpmachine`/bin:$PATH
> >>>> ./configure
> >>>> make
> >>> That would work, but is cumbersome to some extent.
> >>> And if this is the expected way, why bother changing the PATH
> >>> temporarily during configure in the first place?
> >> I agree, if this path is removed, changing PATH in configure.ac should
> >> be removed as well.
> > It should be removed regardless. Adding extras/tools to PATH in configure
> > is an ugly kludge.
> This is a problem. If you have tools in extra/tools they are detected
> during a './configure' call but not during make or './config.status
But that's the point. Don't touch the environment in configure (e.g. PATH) -
unless that change is exposed to the Makefile (e.g. CFLAGS). Otherwise, the
results of the configure tests are potentially invalidated.
> Would that be OK to use AC_PATH_PROGS for programs listed in /extras/tools ?
No, that won't generally work. as already pointed out.
More information about the vlc-devel