[vlc-devel] [vlc-commits] configure.ac: Use AC_PATH_PROGS for luac

[Steve Lhomme]

On Thu, Sep 29, 2016 at 3:27 AM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> Le mercredi 28 septembre 2016, 14:18:44 Steve Lhomme a écrit :
>> On Wed, Aug 3, 2016 at 4:56 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
>> > Le 2016-08-03 15:52, Rafaël Carré a écrit :
>> >> On 08/03/2016 03:49 PM, Hugo Beauzée-Luyssen wrote:
>> >>> On 08/03/2016 03:46 PM, Rafaël Carré wrote:
>> >>>> On 08/03/2016 03:43 PM, Hugo Beauzée-Luyssen wrote:
>> >>>>> I have no problem reverting this patch, but I'd like to have an
>> >>>>> alternative solution which doesn't involve installing luac system wide
>> >>>>> before compiling.
>> >>>>
>> >>>> export PATH=$vlc/contrib/`gcc -dumpmachine`/bin:$PATH
>> >>>> ./configure
>> >>>> make
>> >>>
>> >>> That would work, but is cumbersome to some extent.
>> >>> And if this is the expected way, why bother changing the PATH
>> >>> temporarily during configure in the first place?
>> >>
>> >> I agree, if this path is removed, changing PATH in configure.ac should
>> >> be removed as well.
>> >
>> > It should be removed regardless. Adding extras/tools to PATH in configure
>> > is an ugly kludge.
>>
>> This is a problem. If you have tools in extra/tools they are detected
>> during a './configure' call but not during make or './config.status
>> --recheck'.
>
> But that's the point. Don't touch the environment in configure (e.g. PATH) -
> unless that change is exposed to the Makefile (e.g. CFLAGS). Otherwise, the
> results of the configure tests are potentially invalidated.

But that's exactly what we do in configure.ac, mess with the PATH to
find the extra tools. It's just not propagated after the configure
call. So we end up discovering stuff but when running it, it doesn't
work.
http://git.videolan.org/?p=vlc.git;a=blob;f=configure.ac;h=671c8a1c93c100dbdf8d15cf795ffaf4c6cba222;hb=HEAD#l462

We should be consistent one way or another. I prefer to have
extra/tools programs have their local PATH set. Rather than having to
set a different environment whenever I build from a different folder
(I can use 4 different ones on a daily basis). Which effectively makes
sure we run the extra/tools from the matching folder anyway.

>> Would that be OK to use AC_PATH_PROGS for programs listed in /extras/tools ?
>
> No, that won't generally work. as already pointed out.
>
> --
> Rémi Denis-Courmont
> http://www.remlab.net/
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel