[vlc-devel] [PATCH] Revert "lua: use luaL_checkint() where applicable"

sjw at gmx.ch sjw at gmx.ch
Sat Apr 1 11:06:47 CEST 2017


I was advised to send the patch again on IRC because I had some issues
with the list.

This is the only issue, that prevents me from building VLC on Arch Linux
with Lua 5.3 (x64). See also the patch in the AUR package [1].
In 2468da50f6048be1d4a4ae188fa579f4fe741b40 most luaL_checkint() have
already been replaced and also LUA_COMPAT_APIINTCASTS have been removed.
520b13a2ca88fc63ba3c1287e9314fbb2777c85d revert parts of this, without
adding LUA_COMPAT_APIINTCASTS again and without a clear reason in the
commit message.

Do you have any test infrastructure for those architectures/platforms
that might have trouble with this patch? I would be interested to have a
look at those issues.
Referring to the Lua docs it seems to be a drop-in replacement.


[1] https://aur.archlinux.org/cgit/aur.git/tree/lua53_compat.patch?h=vlc-git

Am 30.03.2017 um 09:47 schrieb Luca Barbato:
> On 26/03/2017 23:00, sjw wrote:
>> This reverts commit 520b13a2ca88fc63ba3c1287e9314fbb2777c85d,
>> because it breaks builds with Lua 5.3.
>> 'luaL_checkint()' is deprecated since Lua 5.3
> Hi, from what I can see from the ml exchange in August Lua 5.3 is not
> really supported and the code is the way it is for a good reason (that
> cast might result in surprising values on certain architectures/platforms).
> It is the second time you are sending this patch, could you please stop?
> lu
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170401/79d00215/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170401/79d00215/attachment.sig>

More information about the vlc-devel mailing list