[vlc-devel] [PATCH 3/4] display: no need to pass the video_format_t for CROP/ASPECT_RATIO changes

[Steve Lhomme]

On Wed, Aug 2, 2017 at 6:06 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> Le keskiviikkona 2. elokuuta 2017, 17.53.11 EEST Steve Lhomme a écrit :
>> > Otherwise we just assume the changes are always accepted.
>>
>> That's not what the current code does.
>
> But it provides no sane way to reject the changes, other than the trivial case

Yes, to reject you return VLC_EGENERIC.

> of a video output that actually ignores crop and A/R entirely (in which case
> the distinction between reject or accept means nothing really).

Are you trying to add features that never existed just for the sake of it ?

> That´s why it´s wrong, leaving things half-simplified in a not very consistent
> shape.
>
> --
> 雷米‧德尼-库尔蒙
> https://www.remlab.net/
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel