[vlc-devel] [PATCH 3/4] display: no need to pass the video_format_t for CROP/ASPECT_RATIO changes

[Rémi Denis-Courmont]

Le 3 août 2017 10:36:32 GMT+03:00, Steve Lhomme <robux4 at gmail.com> a écrit :
>On Wed, Aug 2, 2017 at 6:06 PM, Rémi Denis-Courmont <remi at remlab.net>
>wrote:
>> Le keskiviikkona 2. elokuuta 2017, 17.53.11 EEST Steve Lhomme a écrit
>:
>>> > Otherwise we just assume the changes are always accepted.
>>>
>>> That's not what the current code does.
>>
>> But it provides no sane way to reject the changes, other than the
>trivial case
>
>Yes, to reject you return VLC_EGENERIC.
>
>> of a video output that actually ignores crop and A/R entirely (in
>which case
>> the distinction between reject or accept means nothing really).
>
>Are you trying to add features that never existed just for the sake of
>it ?
>
>> That´s why it´s wrong, leaving things half-simplified in a not very
>consistent
>> shape.
>>
>> --
>> 雷米‧德尼-库尔蒙
>> https://www.remlab.net/
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

No, I am not asking to add nonexistent features. I am asking to be consistent when we remove something. Those 3 patches only make sense if we officially enforce that crop&A/R changes cannot be rejected. Otherwise, committing changes before they are accepted is bad and confusing design at the very least.

I am actually in favor of the simplification, as I am not aware of any problems with it.
-- 
Rémi Denis-Courmont
Typed on an inconvenient virtual keyboard
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170803/e2fb1edf/attachment.html>