[vlc-devel] [vlc-commits] demux: adaptive: missing es_format_Init

[Steve Lhomme]

On Wed, Jul 26, 2017 at 4:39 PM, Francois Cartegnie <git at videolan.org> wrote:
> vlc | branch: master | Francois Cartegnie <fcvlcdev at free.fr> | Wed Jul 26 16:33:21 2017 +0200| [ecdb644390011a2836bb5da9abb9c37926d873dd] | committer: Francois Cartegnie
>
> demux: adaptive: missing es_format_Init
>
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=ecdb644390011a2836bb5da9abb9c37926d873dd
> ---
>
>  modules/demux/adaptive/plumbing/FakeESOut.cpp | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/modules/demux/adaptive/plumbing/FakeESOut.cpp b/modules/demux/adaptive/plumbing/FakeESOut.cpp
> index 47976f2fe1..acc00c0520 100644
> --- a/modules/demux/adaptive/plumbing/FakeESOut.cpp
> +++ b/modules/demux/adaptive/plumbing/FakeESOut.cpp
> @@ -91,6 +91,7 @@ void FakeESOut::setExtraInfoProvider( ExtraFMTInfoInterface *extra )
>  FakeESOutID * FakeESOut::createNewID( const es_format_t *p_fmt )
>  {
>      es_format_t fmtcopy;
> +    es_format_Init( &fmtcopy, p_fmt->i_cat, p_fmt->i_codec );

This is unneeded and has no effect. Copy() overwrites an uninitialized
es_format. If it's initialized it might actually leak dynamic that are
stored in it.

>      es_format_Copy( &fmtcopy, p_fmt );
>      fmtcopy.i_group = 0; /* Always ignore group for adaptive */
>      fmtcopy.i_id = -1;
>
> _______________________________________________
> vlc-commits mailing list
> vlc-commits at videolan.org
> https://mailman.videolan.org/listinfo/vlc-commits