[vlc-devel] [vlc-commits] demux: adaptive: missing es_format_Init

[Francois Cartegnie]

Le 29/08/2017 à 11:51, Steve Lhomme a écrit :

>>  FakeESOutID * FakeESOut::createNewID( const es_format_t *p_fmt )
>>  {
>>      es_format_t fmtcopy;
>> +    es_format_Init( &fmtcopy, p_fmt->i_cat, p_fmt->i_codec );
> 
> This is unneeded and has no effect. Copy() overwrites an uninitialized
> es_format. If it's initialized it might actually leak dynamic that are
> stored in it.
> 

I give up explaining again why Copy shouldn't be used for init.


-- 
Francois Cartegnie
VideoLAN - VLC Developer