[vlc-devel] [PATCH 1/2] misc/actions: Add action for the BD disc popup menu

[Marvin Scholz]

On 6 Dec 2017, at 17:33, Rémi Denis-Courmont wrote:

> There is only one (or zero) popup menu key on any keyboard, and 
> probably any
> reasonable HID.
>
> It does not make much sense to add two actions if there is only one 
> key.
> Nobody will be able to use it.

What do you mean by that? Which two actions? And what would you suggest 
instead?

The user needs some way to trigger the POPUP MENU for bluray discs.

>
> Le keskiviikkona 6. joulukuuta 2017, 17.19.15 EET Marvin Scholz a 
> écrit :
>> Ref #18772
>> ---
>>  include/vlc_actions.h | 1 +
>>  src/misc/actions.c    | 1 +
>>  2 files changed, 2 insertions(+)
>>
>> diff --git a/include/vlc_actions.h b/include/vlc_actions.h
>> index 404c1662a8..8562d9dbe9 100644
>> --- a/include/vlc_actions.h
>> +++ b/include/vlc_actions.h
>> @@ -199,6 +199,7 @@ typedef enum vlc_action_id {
>>      ACTIONID_SNAPSHOT,
>>      ACTIONID_RECORD,
>>      ACTIONID_DISC_MENU,
>> +    ACTIONID_DISC_POPUP_MENU,
>>      ACTIONID_ASPECT_RATIO,
>>      ACTIONID_CROP,
>>      ACTIONID_DEINTERLACE,
>> diff --git a/src/misc/actions.c b/src/misc/actions.c
>> index 65178c1bf4..43550a062c 100644
>> --- a/src/misc/actions.c
>> +++ b/src/misc/actions.c
>> @@ -281,6 +281,7 @@ static const struct name2action
>>      { "deinterlace", ACTIONID_DEINTERLACE, },
>>      { "deinterlace-mode", ACTIONID_DEINTERLACE_MODE, },
>>      { "disc-menu", ACTIONID_DISC_MENU, },
>> +    { "disc-popup-menu", ACTIONID_DISC_POPUP_MENU, },
>>      { "faster", ACTIONID_FASTER, },
>>      { "frame-next", ACTIONID_FRAME_NEXT, },
>>      { "incr-scalefactor", ACTIONID_SCALE_UP, },
>
>
> -- 
> 雷米‧德尼-库尔蒙
> https://www.remlab.net/
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel