[vlc-devel] [PATCH 2/8] modules/stream_extractor: added libarchive extractor
filip at atch.se
Wed Feb 1 19:32:23 CET 2017
On 2017-02-01 20:22, Rémi Denis-Courmont wrote:
> I have a hard time following the code. It really does not help that directory
> and file callbacks appear to be artificially multiplexed.
It might be easier if I supplied some additional comments explaining
what the different callbacks are for, but in short:
- functions that begin with `libarchive_` are callback used by
*libarchive* in order to read from the *VLC* `stream_t` (the
- functions that begin with `archive_` are helpers used by the
*stream-extractor* itself (such as for setting up the `libarchive_`
- functions that begin with a capital letter (`Open`, `Read`, `Seek`,
`Control`, `Close`) are the callbacks supplied to the *vlc core*.
The reason it might feel like there is duplicate behavior is probably
due to the fact that *libarchive* requires callbacks in order to read
from the source `stream_t`, which requires the same functionality as
that exposed to the *vlc core* through the regular `pf_read` (etc.).
Do you think comments that include the information posted above will
aid in terms of following the implementation?
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the vlc-devel