[vlc-devel] [PATCH 2/8] modules/stream_extractor: added libarchive extractor

Filip Roséen filip at atch.se
Wed Feb 1 19:46:34 CET 2017

Hi Rémi (and all others reading),

On 2017-02-01 19:32, Filip Roséen wrote:

> On 2017-02-01 20:22, Rémi Denis-Courmont wrote:
> > I have a hard time following the code. It really does not help that directory 
> > and file callbacks appear to be artificially multiplexed.
> It might be easier if I supplied some additional comments explaining
> what the different callbacks are for, but in short:
> [ snip ... ]
> Do you think comments that include the information posted above will
> aid in terms of following the implementation?

I know realized that I read your email wrong, for some reason my brain
filtered out your usage of *multiplexing*. 

The multiplexing is part of the implemenation given that formats (such
as *rar*) can be split up across several pieces, meaning that we have
to stitch them together (so reading from one, and then moving to the
next/prev when *libarchive* feels so is appropriate (through

I have yet to find a good documentation for *libarchive*, and I spent
most time reading commits to the relevant library (as well as digging
through the source code to get a deeper understanding of how things
are supposed to work).

In either case, below is a link that might help (unless it is the
implementation itself that is causing confusion, and not the API exposed by

 - https://github.com/libarchive/libarchive/wiki/ManualPages
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170201/05ff92b0/attachment.html>

More information about the vlc-devel mailing list