[vlc-devel] [PATCH 0/8] Replace decoder_t pf_decoder_* callbacks

Thomas Guillem thomas at gllm.fr
Thu Feb 9 10:48:27 CET 2017

On Wed, Feb 8, 2017, at 20:10, Francois Cartegnie wrote:
> Le 08/02/2017 à 19:53, Thomas Guillem a écrit :
> > As discussed during the FOSDEM. Here is the big replacement of every
> > pf_decoder_* callbacks.
> > 
> > This new callback is simpler to handle, no more pointer of pointer to set or
> > reset (in the past, a lot of modules has been fixed because there were leaking
> > a *pp_block). Decoder modules will also be able to return a new status.
> > 
> > I tested transcode, a lot of decoder modules, and I was able to build every
> > modules (expect mmal). Everything are on the commits (04/05/06).
> I have the feeling this will break CC extraction due to now possible out
> of sync pf_decode and pf_get_cc.

For the Video Decoder, DecoderGetCc() can be called from any thread
(protected by a mutex) from decoder_QueueVideo(). Should we call this
callback after pf_decode() instead ? Should we add a decoder_QueueCC
function ? It's hard to tell since there is only one (not used) video
decoder that use pf_get_cc: libmpeg2.

If we don't plan to have any others decoders using pf_get_cc, maybe this
should be a packetizer call.

> Francois
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

More information about the vlc-devel mailing list