[vlc-devel] [PATCH 0/8] Replace decoder_t pf_decoder_* callbacks

[Francois Cartegnie]

Le 09/02/2017 à 10:48, Thomas Guillem a écrit :
>> I have the feeling this will break CC extraction due to now possible out
>> of sync pf_decode and pf_get_cc.
> 
> For the Video Decoder, DecoderGetCc() can be called from any thread
> (protected by a mutex) from decoder_QueueVideo(). Should we call this
> callback after pf_decode() instead ? Should we add a decoder_QueueCC
> function ? It's hard to tell since there is only one (not used) video
> decoder that use pf_get_cc: libmpeg2.

Not in main stream.

The GetCC returns data which should be associated with a frame.
(we do not support block/picture metadata like avcodec does)

Since the caller is no longer the same, there's no more guarantee of 1
to 1.

I need to fully check consequences.

> If we don't plan to have any others decoders using pf_get_cc, maybe this
> should be a packetizer call.

No. Decoders also must handle it.

Francois