[vlc-devel] [PATCH] contribs: ffmpeg: subst path separators
filip at atch.se
Mon Feb 20 19:21:30 CET 2017
Hi Rémi and Francois,
On 2017-02-20 18:30, Rémi Denis-Courmont wrote:
> Le maanantaina 20. helmikuuta 2017, 14.23.53 EET Francois Cartegnie a écrit :
> > allows using a non ffmpeg HEAD reference
> I have no clue what that is supposed to mean.
My guess is that Francois would like to be able to specify
`FFMPEG_HASH=` as (example) *"refs/heads/release/12"* without running
into issues because of the slashes (and potential dots).
I would however propose renaming `FFMPEG_HASH` to `FFMPEG_HEAD`, as
the latter is a more accurate name given the accepted contents.
Currently `FFMPEG_HASH` of course accepts any *hash* (including
*"HEAD"*) since such does not include the previously mentioned
> Surely the current code handles references other than "HEAD".
There is however a problem with the patch, and given that I just
noticed that it got pushed I will reply to the relevant commit instead
of outlining it here.
Not tested as I am on a very slow connection and don't feel like
emulating the retrieval, but `contrib/src/ffmpeg/rules.mak:219` (post
patch) uses `FFMPEG_HASH` instead of `FFMPEG_BASENAME`.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the vlc-devel