[vlc-devel] [PATCH 0/8] Re: re-rework archive extraction

Filip Roséen filip at atch.se
Mon Feb 20 14:36:47 CET 2017


Hi `vlc-devel`,

Attached to this post are `8` patches where `5` have been updated to
comply with the desired changes as denoted in the below linked posts
(by *Rémi Denis-Courmount*):

 - https://mailman.videolan.org/pipermail/vlc-devel/2017-February/111570.html
 - https://mailman.videolan.org/pipermail/vlc-devel/2017-February/111571.html

To summarize the differences between the originally proposed
implementation, and the now attached revision, is:

 - Merge *struct-declaration* and *typedef specifier* for `stream_extractor_t`
   and `stream_directory_t` in `include/vlc_stream_extractor.h`.

 - Fix unfortunate typos related to documentation of the implementation
   ("\ref" vs a single backslash).

 - Include rationale for legacy code removal in commit message (it now
   mentions that the relevant functionality is handled by the
   introduced *libarchive* based *stream-extractor*).

I expect these patches to be easily viewed at *patches.videolan.org*,
and with a little bit of luck the below will refer to this very
content (but I am basically just guessing now):

 - https://patches.videolan.org/patch/15672/

If anything b0rkes out, the relevant branch is also available here:

 - https://github.com/FilipRoseen-refp/vlc/tree/stream_extractor-split

Best Regards,\
Filip Roséen

On 2017-02-16 22:44, Filip Roséen wrote:

> These set of patches are a direct adjustment to the thoughts expressed in the
> replies to the previously submitted patch-batch (linked below):
> 
>  - https://mailman.videolan.org/pipermail/vlc-devel/2017-January/111193.html
>  - https://mailman.videolan.org/pipermail/vlc-devel/2017-February/111354.html
> 
> Those patches that are affected by replies shall have a "REVISION #N" marker,
> where the details of the changes and rationale are listed.
> 
> "Revision #1" corresponds to the first thread (as linked previously in this cover
> letter), while "Revision #2" refers to the second thread (about the unnecessary
> joint capability for the equivalent of pf_readdir vs pf_{read,block}).
> 
> Thanks to *Hugo Beauzée-Luyseen* and *Rémi Denis-Courmount* for their feedback.
> 
> Filip Roséen (8):
>   stream_extractor: split joint capability into two
>   modules/stream_extractor: added libarchive extractor
>   gui/skins2: add ThemeLoader::unarchive
>   gui/skins2: use ThemeLoader::unarchive
>   gui/skins2: remove legacy archive dependencies
>   modules/access: remove legacy rar access
>   modules/access: removal of legacy archive access/filter
>   access: remove legacy zip accessor/stream
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170220/99f47dfb/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-stream_extractor-split-joint-capability-into-two.patch
Type: text/x-diff
Size: 20494 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170220/99f47dfb/attachment-0008.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-modules-stream_extractor-added-libarchive-extractor.patch
Type: text/x-diff
Size: 22304 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170220/99f47dfb/attachment-0009.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-gui-skins2-add-ThemeLoader-unarchive.patch
Type: text/x-diff
Size: 7845 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170220/99f47dfb/attachment-0010.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-gui-skins2-use-ThemeLoader-unarchive.patch
Type: text/x-diff
Size: 1049 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170220/99f47dfb/attachment-0011.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-gui-skins2-remove-legacy-archive-dependencies.patch
Type: text/x-diff
Size: 22370 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170220/99f47dfb/attachment-0012.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-modules-access-remove-legacy-rar-access.patch
Type: text/x-diff
Size: 30181 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170220/99f47dfb/attachment-0013.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-modules-access-removal-of-legacy-archive-access-filt.patch
Type: text/x-diff
Size: 29085 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170220/99f47dfb/attachment-0014.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-access-remove-legacy-zip-accessor-stream.patch
Type: text/x-diff
Size: 95830 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170220/99f47dfb/attachment-0015.patch>


More information about the vlc-devel mailing list