[vlc-devel] [PATCH] network/httpd: use designated initializers for struct iovec

Filip Roséen filip at atch.se
Sun Feb 26 15:54:40 CET 2017

Hi Rémi,

On 2017-02-26 16:47, Rémi Denis-Courmont wrote:

> Le sunnuntaina 26. helmikuuta 2017, 15.03.16 EET Filip Roséen a écrit :
> > Given that POSIX does not guarantee the order (nor the number) of the
> > data-members within "struct iovec", we should either use designated
> > initializers, or direct member-access, to initialize struct iovec.{iov_base,
> > iov_len}.
> It´s not the only place with that theoretical problem.

I just remember fixing it in `src/misc/interrupt.c` a long time ago,
and when reading your recent commit it caught my attention (so I
decided to take a few seconds to fix it).

I honestly assumed that *past-Filip* was smart enough to look for
other cases when he (me) wrote `02cd3e0`, but as it turns out; he (me)
was not.

 - http://git.videolan.org/?p=vlc.git;a=commit;h=02cd3e04358437fa6f34493dd4aeb72007d734b7

Changes for the remaining issues of this kind will be pushed to
`vlc-devel` as soon as I am done with a really annoying bug in a
3rd-party library.

Thanks for letting me know!

Best Regards,\
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170226/251bc4cb/attachment.html>

More information about the vlc-devel mailing list