[vlc-devel] [PATCH] network/httpd: use designated initializers for struct iovec
Filip Roséen
filip at atch.se
Sun Feb 26 16:59:58 CET 2017
Hi again,
On 2017-02-26 15:54, Filip Roséen wrote:
> On 2017-02-26 16:47, Rémi Denis-Courmont wrote:
> > It´s not the only place with that theoretical problem.
So I took some time to look for all cases where we initialize a
`struct iovec` without being explicit about what we are initializing,
and ended up with the below linked patch:
- https://patches.videolan.org/patch/15742/
I checked things twice (in terms of usage), but could only find two
places (in `access/dtv` and `stream_filter/decomp`); if there are more
cases of former usage that I could not find I apologize for the
inconvenience.
> I just remember fixing it in `src/misc/interrupt.c` a long time ago,
> and when reading your recent commit it caught my attention (so I
> decided to take a few seconds to fix it).
>
> I honestly assumed that *past-Filip* was smart enough to look for
> other cases when he (me) wrote `02cd3e0`, but as it turns out; he (me)
> was not.
>
> - http://git.videolan.org/?p=vlc.git;a=commit;h=02cd3e04358437fa6f34493dd4aeb72007d734b7
>
> Changes for the remaining issues of this kind will be pushed to
> `vlc-devel` as soon as I am done with a really annoying bug in a
> 3rd-party library.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170226/12b762c5/attachment.html>
More information about the vlc-devel
mailing list