[vlc-devel] [PATCH 2/6] configure: add check for attributes

Filip Roséen filip at atch.se
Sun Feb 26 20:45:38 CET 2017

Hi Rémi,

On 2017-02-26 21:27, Rémi Denis-Courmont wrote:

> As has been noted many times over, the VLC headers CANNOT depend on configure 
> output (since they are installed by the plugin SDK).
> That is why all public headers use compiler/version checks.
> So obvious nack.

What do you propose as an alternative? I am not too keen on supplying
`-Wno-unknown-attributes` for the relevant compilers, and sprinkling
things like `!defined( clang )` everywhere seems rather unpleasent.

Of course, the relevant (proposed) functionality could be implemented
in the public headers with the compiler/version checks in place;

 - would that be a suitable alternative?

> And with that said, if your compiler defines __GNUC__, it has to support GCC 
> extensions. That´s kind of the whole point. So looks like your compiler is 
> buggy.

`clang` supports the relevant attributes starting with `5.0`,
compiling VLC with `3.9.0` reproduces the described situation.

The same, of course, applies to the *buildbots* where one can see the
described behavior in logs such as the ones below:

 - https://jenkins.videolan.org/job/vlc-nightly/job/vlc-nightly-macOS/211/consoleText
 - https://jenkins.videolan.org/job/vlc-android/job/android-bin-x86/1011/consoleText

> -- 
> 雷米‧德尼-库尔蒙
> https://www.remlab.net/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170226/f640c941/attachment.html>

More information about the vlc-devel mailing list