[vlc-devel] [PATCH 3/3] dca: re-order libm to fix linking (fixes #17838)

[Rémi Denis-Courmont]

Le dimanche 1 janvier 2017, 17:13:16 Sean McGovern a écrit :
> ---
>  modules/codec/Makefile.am | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/modules/codec/Makefile.am b/modules/codec/Makefile.am
> index 893f3c4..ed972ab 100644
> --- a/modules/codec/Makefile.am
> +++ b/modules/codec/Makefile.am
> @@ -26,7 +26,7 @@ codec_LTLIBRARIES += $(LTLIBa52)
>  libdca_plugin_la_SOURCES = codec/dca.c
>  libdca_plugin_la_CPPFLAGS = $(AM_CPPFLAGS) $(DCA_CFLAGS)
>  libdca_plugin_la_LDFLAGS = $(AM_LDFLAGS) -rpath '$(codecdir)'
> -libdca_plugin_la_LIBADD = $(LIBM) $(DCA_LIBS)
> +libdca_plugin_la_LIBADD = $(DCA_LIBS) $(LIBM)
>  EXTRA_LTLIBRARIES += libdca_plugin.la
>  codec_LTLIBRARIES += $(LTLIBdca)

The order should't matter for VLC's own usage of <math.h>.

But this seems wrong either way: dca.c does not even depend on <math.h> 
AFAICT. $(DCA_LIBS) is probably missing -lm.

-- 
Rémi Denis-Courmont
http://www.remlab.net/