[vlc-devel] [vlc-commits] input: unset pointer to titles on source deletion (fix #17944)

[Rémi Denis-Courmont]

Le perjantaina 27. tammikuuta 2017, 18.18.14 EET Francois Cartegnie a écrit :
> vlc | branch: master | Francois Cartegnie <fcvlcdev at free.fr> | Fri Jan 27
> 18:13:26 2017 +0100| [39ae821cf60b209793b767b37d173fb0ee6a9e61] |
> committer: Francois Cartegnie
> 
> input: unset pointer to titles on source deletion (fix #17944)
> 
> > http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=39ae821cf60b209793b
> > 767b37d173fb0ee6a9e61
> ---
> 
>  src/input/input.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/src/input/input.c b/src/input/input.c
> index 3552928..9eead35 100644
> --- a/src/input/input.c
> +++ b/src/input/input.c
> @@ -1446,6 +1446,10 @@ static void End( input_thread_t * p_input )
> 
>      /* Clean up master */
>      InputSourceDestroy( priv->master );
> +    priv->i_title = 0;
> +    priv->title = NULL;
> +    priv->i_title_offset = 0;
> +    priv->i_seekpoint_offset = 0;

AFAICT, this does not solve the bug, and might make things even worse in some 
cases. The memory access policy for those variables seems incoherent.

(This is NOT to deny that there was a bug.)

> 
>      /* Unload all modules */
>      if( priv->p_es_out )
> 
> _______________________________________________
> vlc-commits mailing list
> vlc-commits at videolan.org
> https://mailman.videolan.org/listinfo/vlc-commits


-- 
雷米‧德尼-库尔蒙
https://www.remlab.net/