[vlc-devel] [PATCH 1/2] core-vout: increase maximum format size from 8k to 32k

[Rémi Denis-Courmont]

Le 7 juillet 2017 18:19:29 GMT+03:00, Victorien Le Couviour--Tuffet <victorien.lecouviour.tuffet at gmail.com> a écrit :
>This allows the vout to handle more than 8k formats, and partially
>fixes the
>issue #18215, as the vout failed to open due to this restriction. We
>now have
>to check for the maximum size the HW can handle, and resize to it if
>bigger.
>---
> src/video_output/video_output.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/src/video_output/video_output.c
>b/src/video_output/video_output.c
>index 2f11ebeec3..ca20539c7d 100644
>--- a/src/video_output/video_output.c
>+++ b/src/video_output/video_output.c
>@@ -78,8 +78,8 @@ static void VoutDestructor(vlc_object_t *);
> static int VoutValidateFormat(video_format_t *dst,
>                               const video_format_t *src)
> {
>-    if (src->i_width == 0  || src->i_width  > 8192 ||
>-        src->i_height == 0 || src->i_height > 8192)
>+    if (src->i_width == 0  || src->i_width  > 32768 ||
>+        src->i_height == 0 || src->i_height > 32768)
>         return VLC_EGENERIC;
>     if (src->i_sar_num <= 0 || src->i_sar_den <= 0)
>         return VLC_EGENERIC;
>-- 
>2.13.1
>
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

You most probably can't just do that. This will most probably lead to overflow in 32-bits arithmetic, and I can't see any attempt to address that in the patch series.
-- 
Rémi Denis-Courmont
Typed on an inconvenient virtual keyboard
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170707/f7ed9376/attachment.html>