[vlc-devel] [PATCH 1/2] core-vout: increase maximum format size from 8k to 32k

[Jean-Baptiste Kempf]

Hello,

On Fri, 7 Jul 2017, at 17:23, Rémi Denis-Courmont wrote:
> -    if (src->i_width == 0  || src->i_width  > 8192 ||
>> -        src->i_height == 0 || src->i_height > 8192)
>> 
>> +    if (src->i_width == 0  || src->i_width  > 32768 ||
>> 
>> +        src->i_height == 0 || src->i_height > 32768)
>> 
>>          return VLC_EGENERIC;
>> 
>>      if (src->i_sar_num <= 0 || src->i_sar_den <= 0)
>> 
>>          return VLC_EGENERIC;
>> 
> 
> You most probably can't just do that. This will most probably lead to overflow in 32-bits arithmetic, and I can't see any attempt to address that in the patch series.
Are you speaking about the picture size?

2^15*2^15*4 (planes) ?

Would staying at 2^14 be better, for now?


--
Jean-Baptiste Kempf -  President
+33 672 704 734
 


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170707/5f3310f5/attachment.html>