[vlc-devel] [PATCH] vlc_common.h: include the local variant of vlc_array.h

Rémi Denis-Courmont remi at remlab.net
Thu Jul 13 16:10:58 CEST 2017


On jeudi 13 juillet 2017 14:50:29 EEST Steve Lhomme wrote:
> ---
>  include/vlc_common.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/vlc_common.h b/include/vlc_common.h
> index 94ab07e7a1..c1464f3eea 100644
> --- a/include/vlc_common.h
> +++ b/include/vlc_common.h
> @@ -670,7 +670,7 @@ static inline uint64_t (bswap64)(uint64_t x)
> 
>  VLC_API char const * vlc_error( int ) VLC_USED;
> 
> -#include <vlc_arrays.h>
> +#include "vlc_arrays.h"
> 
>  /* MSB (big endian)/LSB (little endian) conversions - network order is
> always * MSB, and should be used for both network communications and files.
> */

This patch is totally inconsistent with the rest of the include directory (or 
almost all of it). On top of that, it seems totally gratuitious.

-- 
Rémi Denis-Courmont


More information about the vlc-devel mailing list