[vlc-devel] [PATCH] vlc_common.h: include the local variant of vlc_array.h

[Steve Lhomme]

On Thu, Jul 13, 2017 at 4:10 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> On jeudi 13 juillet 2017 14:50:29 EEST Steve Lhomme wrote:
>> ---
>>  include/vlc_common.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/vlc_common.h b/include/vlc_common.h
>> index 94ab07e7a1..c1464f3eea 100644
>> --- a/include/vlc_common.h
>> +++ b/include/vlc_common.h
>> @@ -670,7 +670,7 @@ static inline uint64_t (bswap64)(uint64_t x)
>>
>>  VLC_API char const * vlc_error( int ) VLC_USED;
>>
>> -#include <vlc_arrays.h>
>> +#include "vlc_arrays.h"
>>
>>  /* MSB (big endian)/LSB (little endian) conversions - network order is
>> always * MSB, and should be used for both network communications and files.
>> */
>
> This patch is totally inconsistent with the rest of the include directory (or

Correct.

> almost all of it). On top of that, it seems totally gratuitious.

That's the only line that's inconsistent with the rest of that file so
IMO it makes sense.
The whole include directory could do with some cleaning. But I have
enough pending patches to have big ones pending while other less
important are waiting.

> --
> Rémi Denis-Courmont
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel