[vlc-devel] [PATCH 2/2] contrib:libarchive: force static build

[Rémi Denis-Courmont]

On mardi 18 juillet 2017 15:30:54 EEST Derek Buitenhuis wrote:
> On 7/18/2017 3:26 PM, Steve Lhomme wrote:
> > ++Cflags: -I${includedir} -DLIBARCHIVE_STATIC
> 
> Shouldn't this be in the VLC CFLAGS or defined where the header is included
> rather than the libarchive pkg-config file?

It should be defined in VLC if it were a property of the code base linking the 
library. But if it is a property of the library build, then it should either 
be in the library header file(s) or the pkg-config file, I think.

(And IIUC, this is the later case.)

In principles, assuming that Cflags.static exists, then it should probably be 
added there inconditionally (in upstream), and the VLC contrib rules should 
run pkg-static.sh. But this is just a more circumvoluted path to the same 
result.

-- 
Rémi Denis-Courmont