[vlc-devel] [PATCH 2/2] contrib:libarchive: force static build

[Derek Buitenhuis]

On 7/18/2017 3:47 PM, Rémi Denis-Courmont wrote:
> It should be defined in VLC if it were a property of the code base linking the 
> library. But if it is a property of the library build, then it should either 
> be in the library header file(s) or the pkg-config file, I think.
> 
> (And IIUC, this is the later case.)

I'm kind of split. It's not easy to do upstream, due to the case where you build
both static and shared libs at the same time (then what you put in the header is
not determinable at library built time).

Stuff like libx264 does this the same way (shunting the responsibility onto
the user):

    http://git.videolan.org/?p=x264.git;a=blob;f=x264.h;h=0f34067297ed248dc45752ce8f1961d0bd51676c;hb=HEAD#l50

That's why I suggested it go in VLC's CFLAGS. I guess the answer is just "there's
no correct answer and Windows is silly".

> In principles, assuming that Cflags.static exists, then it should probably be 
> added there inconditionally (in upstream), and the VLC contrib rules should 
> run pkg-static.sh. But this is just a more circumvoluted path to the same 
> result.

Doesn't exist, unfortunately, since this is pretty much exclusively a Windows problem.

- Derek