[vlc-devel] [PATCH] gstreamer: fix memory leak

[Thomas Guillem]

On Mon, Jul 24, 2017, at 10:42, Shaleen Jain wrote:
> Merge this as well?
> Not being able to handle a GstMessage is no reason to preempt closing the decoder.> Regards, Shaleen Jain

if default_msg_handler() returns true, this means the GstMessage is well handled and is an error.Here, this means than gst time outed.  I'm not familiar at all with gst or this module but I guess we can't do much cleanup in case of timeout and it's may be better to leak than to deadlock.
> On Mon, Jul 24, 2017 at 10:16 AM, Shaleen Jain <shaleen.jain95 at gmail.com> wrote:>> --- modules/codec/gstreamer/gstdecode.c | 1 - 1 file changed, 1 deletion(-)  diff --git a/modules/codec/gstreamer/gstdecode.c b/modules/codec/gstreamer/gstdecode.c index 05aa500205..bbe6310291 100644 --- a/modules/codec/gstreamer/gstdecode.c +++ b/modules/codec/gstreamer/gstdecode.c @@ -838,7 +838,6 @@ static void CloseDecoder( vlc_object_t *p_this ) if( default_msg_handler( p_dec, p_msg ) ) { msg_Err( p_dec, "pipeline may not close gracefully" ); -                    return; } break; } >> --
>> 2.13.3 
> _________________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170724/d1cf18d3/attachment.html>