[vlc-devel] [PATCH] input: decoder: fix audio GET_EMPTY mid stream

Francois Cartegnie fcvlcdev at free.fr
Thu Jun 29 14:47:22 CEST 2017

Le 29/06/2017 à 14:22, Rémi Denis-Courmont a écrit :
> It is entirely possible that the FIFO is empty while audio is playing. In fact, this is very likely as audio outputs tend to have large playout buffers, such that the decoder FIFO is most often empty.
> So this looks totally wrong.

I did not remove aout_IsEmpty().

And even if we still had it, DecoderIsEmpty() should test decoder...
That's not the case for vout (and that's probably another issue) and
wasn't the case for aout.
Today's aout only tests draining (EOF) which is wrong and broke menus.

Unless we have proper aout_IsEmpty(), assuming the audio is in sync with
video, is to consider audio as always empty, or at least, test if
decoder has finished its job (what this patch does).


More information about the vlc-devel mailing list