[vlc-devel] [PATCH] input: decoder: fix audio GET_EMPTY mid stream
remi at remlab.net
Thu Jun 29 15:08:06 CEST 2017
Le 29 juin 2017 15:47:22 GMT+03:00, Francois Cartegnie <fcvlcdev at free.fr> a écrit :
>Le 29/06/2017 à 14:22, Rémi Denis-Courmont a écrit :
>> It is entirely possible that the FIFO is empty while audio is
>playing. In fact, this is very likely as audio outputs tend to have
>large playout buffers, such that the decoder FIFO is most often empty.
>> So this looks totally wrong.
>I did not remove aout_IsEmpty().
>And even if we still had it, DecoderIsEmpty() should test decoder...
>That's not the case for vout (and that's probably another issue) and
>wasn't the case for aout.
>Today's aout only tests draining (EOF) which is wrong and broke menus.
>Unless we have proper aout_IsEmpty(), assuming the audio is in sync
>video, is to consider audio as always empty, or at least, test if
>decoder has finished its job (what this patch does).
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
Audio is never empty until flush or drain has completed. That's how audio works.
Typed on an inconvenient virtual keyboard
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the vlc-devel