[vlc-devel] [PATCH 02/23] macosx: helpers: add getVouts

[Victorien Le Couviour--Tuffet]

On Thu, Jun 29, 2017 at 03:14:53PM +0200, Marvin Scholz wrote:
> On 29 Jun 2017, at 15:03, Victorien Le Couviour--Tuffet wrote:
> > On Thu, Jun 29, 2017 at 02:46:20PM +0200, Marvin Scholz wrote:
> > > Thanks for your patches.
> > > 
> > 
> > You're welcome.
> > 
> > > On 29 Jun 2017, at 14:24, Victorien Le Couviour--Tuffet wrote:
> > > 
> > > > +static inline NSArray<NSValue *> *getVouts(void)
> > > 
> > > I don't think we can use type annotated arrays yet, given that VLC
> > > still
> > > needs to build with
> > > old Xcode versions, for now.
> > 
> > What is the version you have in mind? I'm compiling with the default
> > value of
> > --with-macosx-version-min which is 10.7.
> 
> This will not have any effect on this.
> --with-macosx-version-min only sets the target macOS version.
> 
> This is about the Objective C/Xcode version.
> I've just checked again and Lightweight Generics were introduces with Xcode
> 7,
> so it's fine to use them given that (afaik) we do not need to support
> anything
> older.
> 
> My comment about that is therefore void, sorry.

No problem.