[vlc-devel] [PATCH v2 05/18] newlib/nacl: Provide flockfile implementation

[Dennis Hamester]

On 03/13/2017 08:09 PM, Rémi Denis-Courmont wrote:
> Le maanantaina 13. maaliskuuta 2017, 12.36.51 EET Dennis Hamester a écrit :
>> From: Julian Scheel <julian at jusst.de>
>>
>> newlib does not provide a flockfile implementation currently. Use the
>> existing compat implementation from win32.
>>
>> Signed-off-by: Julian Scheel <julian at jusst.de>
>> ---
>>  compat/flockfile.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/compat/flockfile.c b/compat/flockfile.c
>> index afe8a3e111..bef83f9895 100644
>> --- a/compat/flockfile.c
>> +++ b/compat/flockfile.c
>> @@ -24,7 +24,7 @@
>>
>>  #include <stdio.h>
>>
>> -#ifdef _WIN32
>> +#if defined(_WIN32) || defined(_NEWLIB_VERSION)
>>  # ifndef HAVE__LOCK_FILE
>>  #  warning Broken SDK: VLC logs will be garbage.
>>  #  define _lock_file(s) ((void)(s))
> 
> That does not answer the question. This only makes sense if NaCl has Windows-
> compatible _lock_file().
> 
> 

The use of _lock_file is guarded by an #ifndef HAVE__LOCK_FILE. On NaCl,
that is not the case -> Everyone is happy.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 862 bytes
Desc: OpenPGP digital signature
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170313/e1e3493d/attachment.sig>