[vlc-devel] [PATCH v2 05/18] newlib/nacl: Provide flockfile implementation

Rémi Denis-Courmont remi at remlab.net
Mon Mar 13 21:14:25 CET 2017

Le maanantaina 13. maaliskuuta 2017, 20.45.08 EET Dennis Hamester a écrit :
> > That does not answer the question. This only makes sense if NaCl has
> > Windows- compatible _lock_file().
> The use of _lock_file is guarded by an #ifndef HAVE__LOCK_FILE. On NaCl,
> that is not the case -> Everyone is happy.

I don´t currently use Native Client. If I did, I wouldn´t be happy to have 
unusable logs, if not crashes, due to concurrent access to FILE pointers.

But in any case, this code only makes sense on Windows, and it´s only that way 
to work around a MingW problem. (I don´t know if it´s a MingW bug or a VLC 
build misconfiguration.) Using it for anything else is confusing and likely to 
explode when the MingW problem is resolved - and the code removed.


More information about the vlc-devel mailing list