[vlc-devel] [PATCH 1/2] vout: add vout_Drain()

[Thomas Guillem]

There is one big issue that is also present with the aout drain.



Drains are synchronous, the decoder can't process any commands during
the draining (like pause or quit).
If there is 1 seconds of picture to drain, the decoder (hence the
input, hence the UI) won't be able to stop for 1 seconds if the user
requested it.


We could do an asynchronous drain for the vout, with more cond/lock
complexity in decoder.c.
But for the aout, it will be more complicated, we'll have to modify the
drain implementation of all our modules.


On Wed, Mar 15, 2017, at 15:49, Filip Roséen wrote:

> Hi Rémi (and Thomas),



> On 2017-03-15 16:44, Rémi Denis-Courmont wrote:


>>  On March 15, 2017 4:33:30 PM GMT+02:00, Thomas Guillem
>>  <thomas at gllm.fr> wrote:
>>> vout_Drain() asks the vout thread to drain its queued pictures. This
>>> function will wait for the last picture to be displayed.  Refs
>>> #18105
>>  Fine With me but I fear this sort of thing is not to the liking of
>>  the ES output buffering code.
> The ES buffering code does *sadly* not care about neither decoder nor
> {audio,video}-output, so this patch should not affect anything in
> terms of buffering from the *es-out*’s point of view.
> _________________________________________________

> vlc-devel mailing list

> To unsubscribe or modify your subscription options:

> https://mailman.videolan.org/listinfo/vlc-devel


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170315/9a6e9e2f/attachment.html>