[vlc-devel] [PATCH 1/2] tests: Do not use -static for hxxx on darwin

[Filip Roséen]

Hi Rémi,

On 2017-03-16 15:52, Rémi Denis-Courmont wrote:

> On jeudi 16 mars 2017 12:20:35 EET Marvin Scholz wrote:
>
> >  test_modules_packetizer_hxxx_LDFLAGS = -no-install -static # WTF
> > +endif
> >  test_modules_keystore_SOURCES = modules/keystore/test.c
> >  test_modules_keystore_LDADD = $(LIBVLCCORE) $(LIBVLC)
> >  test_modules_tls_SOURCES = modules/misc/tls.c
> 
> Removing -no-install makes no sense: Those targets are not meant to be 
> installed. In fact, -no-install should be set for all noinst_- and 
> check_PROGRAMS targets (and obviously MUST NOT be used for any other PROGRAMS 
> target).
> 
> I am not sure if -static still carries any meaning, since libvlc and 
> libvlccore are not built statically in any case. IIRC, in some versions of 
> libtool, it is or was necessary to make -no-install actually work. But it 
> might also be cargo cult. But maybe ask whomever wrote "# WTF" there??

You did, in [`2b5b2845f34`][1].

[1]: http://git.videolan.org/?p=vlc.git;a=commitdiff;h=2b5b2845f34;hp=062c2c3ea191fc7228bd8fe7e4771c1b43ff196f

> 
> So in any case, this does not look right.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170316/dfe0d153/attachment.html>