[vlc-devel] [PATCH 5/5] se/archive: react and issue diagnostic on reset-error

[Filip Roséen]

Hi Hugo,

On 2017-03-17 10:54, Hugo Beauzée-Luyssen wrote:

> On Fri, Mar 17, 2017, at 03:22 AM, Filip Roséen wrote:
> > ---
> >  modules/stream_extractor/archive.c | 11 +++++++----
> >  1 file changed, 7 insertions(+), 4 deletions(-)

> > +            if( archive_init( p_sys, p_extractor->source ) ||
> > +                archive_seek_subentry( p_sys, p_extractor->identifier )
> > )
> > +            {
> > +                msg_Err( p_extractor,
> > +                        "fatal: unable to recreate libarchive handle" );
> > +                p_sys->b_dead = false;
> 
> Don't you mean true?

I actually meant to not have that assignment to `p_sys->b_dead` at
all, seems like I did the rebasing a little fast and ended up with a
`fixup` where it should have been a `drop`.

I also just noticed that there is one patch missing from this set. See
attached patch for an updated one, and expect another one being sent
to `vlc-devel` really soon.

> >                  return VLC_EGENERIC;
> > +            }
> >  
> >              i_skip = i_req;
> >              i_offset = 0;
> 
> And assuming you meant `true` doesn't this make patch 4 obsolete? As far
> as I understand the only way of having a NULL p_entry is to have a
> successful archive_clean call followed by a failing archive_init call,
> however you 

Seems your message got truncated, but see earlier paragraph.

Thanks for the review, and happy friday!

Best Regards,\
Filip Roséen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170317/06bb6505/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-se-archive-issue-diagnostic-on-reset-failure.patch
Type: text/x-diff
Size: 1240 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170317/06bb6505/attachment.patch>