[vlc-devel] [PATCH 2/2] tests: Do not use -no-install on darwin

[Marvin Scholz]

On 17 Mar 2017, at 3:13, Rémi Denis-Courmont wrote:

> On jeudi 16 mars 2017 12:20:36 EET Marvin Scholz wrote:
>> ---
>>  test/Makefile.am | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/test/Makefile.am b/test/Makefile.am
>> index 03dacc4..267e230 100644
>> --- a/test/Makefile.am
>> +++ b/test/Makefile.am
>> @@ -77,7 +77,9 @@ samples/meta.sample:
>>  	curl $(SAMPLES_SERVER)/metadata/id3tag/Wesh-Bonneville.mp3 > $@
>>
>>  AM_CFLAGS = -DSRCDIR=\"$(srcdir)\"
>> +if !HAVE_DARWIN
>>  AM_LDFLAGS = -no-install
>> +endif
>>  LIBVLCCORE = -L../src/ -lvlccore
>>  LIBVLC = -L../lib -lvlc
>
> All that this does is slow down the MacOS build and make test cases 
> harder to
> debug. I don't recommend it.

After having another look, I realized my reasoning for this change was 
wrong, so
this patch should be discarded. Thanks for pointing it out.

>
> -- 
> Rémi
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel