[vlc-devel] [PATCH 01/14] direct3d11: factorize the same string usage

[Steve Lhomme]

On Mon, Mar 20, 2017 at 5:31 PM, Hugo Beauzée-Luyssen <hugo at beauzee.fr> wrote:
>
>
> On Mon, Mar 20, 2017, at 05:28 PM, Steve Lhomme wrote:
>> ---
>>  modules/video_output/win32/direct3d11.c | 7 ++++---
>>  1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/modules/video_output/win32/direct3d11.c
>> b/modules/video_output/win32/direct3d11.c
>> index 781103d988..080fa2f1a0 100644
>> --- a/modules/video_output/win32/direct3d11.c
>> +++ b/modules/video_output/win32/direct3d11.c
>> @@ -1588,10 +1588,11 @@ static HRESULT CompilePixelShader(vout_display_t
>> *vd, const d3d_format_t *format
>>  {
>>      vout_display_sys_t *sys = vd->sys;
>>
>> +    static const char *DEFAULT_NOOP = "return rgb";;
>
> Definitely nitpicking, but stray semicolon here.

Indeed and indeed.

>>      const char *psz_sampler;
>> -    const char *psz_src_transform     = "return rgb";
>> -    const char *psz_display_transform = "return rgb";
>> -    const char *psz_tone_mapping      = "return rgb";
>> +    const char *psz_src_transform     = DEFAULT_NOOP;
>> +    const char *psz_display_transform = DEFAULT_NOOP;
>> +    const char *psz_tone_mapping      = DEFAULT_NOOP;
>>
>>      switch (format->formatTexture)
>>      {
>> --
>> 2.11.1
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>
>
> --
>   Hugo Beauzée-Luyssen
>   hugo at beauzee.fr
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel