[vlc-devel] [PATCH] direct3d9: fix orientation

[Salah-Eddin Shaban]

On Thu, Nov 16, 2017 at 4:38 PM, Salah-Eddin Shaban <salah at videolan.org> wrote:
> On Thu, Nov 16, 2017 at 9:36 AM, Steve Lhomme <robux4 at gmail.com> wrote:
>> On Wed, Nov 15, 2017 at 5:12 PM, Salah-Eddin Shaban <salah at videolan.org> wrote:
>>> Hello again,
>>>
>>> As JB requested, I tested this with the samples from #2882, and indeed
>>> there's a problem.
>>>
>>> Without this patch direct3d9 and opengl behave the same for the #2882
>>
>> And also for D3D11 so there's a good chance they have the correct behavior.
>>
>
> Hello Steve,
>
> There is currently an orientation problem in both D3D9 and D3D11 when
> opening RGB video sources in DirectShow, it is explained here:
>
> https://mailman.videolan.org/pipermail/vlc-devel/2017-February/111518.html
>
> This problem does not occur with the opengl vout.
>

OK, I'm using the attached patch to force arbitrary orientations on
png images, and compare the behavior of direct3d9 and opengl.

The ones that direct3d9 currently does wrong are:
ORIENT_TOP_RIGHT
ORIENT_BOTTOM_LEFT
ORIENT_RIGHT_BOTTOM

The #2882 samples are working fine because they use only:
ORIENT_ROTATED_90  (ORIENT_RIGHT_TOP)
ORIENT_ROTATED_180 (ORIENT_BOTTOM_RIGHT)
ORIENT_ROTATED_270 (ORIENT_LEFT_BOTTOM)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-png-add-png-orient-option.patch
Type: application/octet-stream
Size: 1005 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20171117/289eb955/attachment.obj>