[vlc-devel] [PATCH] iconv: add local ISO_6937-2 conversion

[Rémi Denis-Courmont]

Le 23 octobre 2017 10:44:24 GMT+03:00, Thomas Guillem <thomas at gllm.fr> a écrit :
>
>
>On Sun, Oct 22, 2017, at 13:26, Rémi Denis-Courmont wrote:
>> Le lauantaina 21. lokakuuta 2017, 21.07.08 EEST Salah-Eddin Shaban a
>> écrit :
>> > On Sat, Oct 21, 2017 at 9:26 AM, Rémi Denis-Courmont
><remi at remlab.net> 
>> wrote:
>> > > Le keskiviikkona 18. lokakuuta 2017, 23.15.02 EEST Salah-Eddin
>Shaban a
>> > > 
>> > > écrit :
>> > >> On Wed, Oct 18, 2017 at 7:52 PM, Rémi Denis-Courmont
><remi at remlab.net>
>> > > 
>> > > wrote:
>> > >> > Le keskiviikkona 18. lokakuuta 2017, 19.41.01 EEST Salah-Eddin
>Shaban a
>> > >> > 
>> > >> > écrit :
>> > >> >> And use our local conversion on all platforms.
>> > >> > 
>> > >> > No thanks.
>> > >> 
>> > >> ISO_6937 conversion was added to vlc because it was required for
>EPG.
>> > > 
>> > > That replacement code has a number of bugs. I won´t have that on
>systems
>> > > that I use.
>> > 
>> > Is it just me, or are you taking this too personally?
>> > 
>> > So the replacement code has bugs, but you're OK with that as long
>as
>> > those bugs end up on platforms you don't use?
>> 
>> Well, I don't like it, but it´s not my problem. And by the
>grandfather
>> clause, 
>> I can´t just remove the code just because it´s buggy, unless I have a
>
>> replacement, so that´s that.
>
>I could merge the V2 from Salah that don't touch Linux systemes, but I
>don't understand what are the bugs neither. IMHAO, it would be better
>to
>use the same code for all systems.
>
>> 
>> -- 
>> 雷米‧德尼-库尔蒙
>> https://www.remlab.net/
>> 
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

Hi,

I do not perceive any benefit in concealing this code with the iconv wrapper if using a single own implementation. All of the bugs boil down to infelicities in the iconv wrapping.

Of course, one could argue that ISO 6937 revisions should be added to iconv, but I am not sure if that is your point.
-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.