[vlc-devel] [PATCH] iconv: add local ISO_6937-2 conversion

[Salah-Eddin Shaban]

On Mon, Oct 23, 2017 at 11:48 AM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> Hi,
>

Hello all,

> I do not perceive any benefit in concealing this code with the iconv wrapper if using a single own implementation. All of the bugs boil down to infelicities in the iconv wrapping.
>

I think it was done like that for EPG because it can use multiple
charsets, ISO_6937 being one of them. The same is true for EBU STL. So
without the iconv wrapping one would have to call different conversion
functions for different charsets. I'm not sure what else uses these
conversions, or if removing the iconv wrapping breaks anything.

> Of course, one could argue that ISO 6937 revisions should be added to iconv, but I am not sure if that is your point.
>

It's not just about ISO revisions, at least for EPG:

https://lists.gnu.org/archive/html/bug-gnu-libiconv/2009-09/msg00001.html