[vlc-devel] [PATCH 1/4] es: move i_profile/i_level to audio and video format structs

Jean-Baptiste Kempf jb at videolan.org
Mon Apr 2 13:31:04 CEST 2018

On Fri, 30 Mar 2018, at 19:22, RĂ©mi Denis-Courmont wrote:
> audience as the reviewed code. That advice is inapplicable to code review in 
> the context of community open-source projects.

Of course, it is somewhat applicable.

Because, maybe, you should stop saying "makes no sense" to things that can make sense.

1 == 0 makes no sense, coding with anti-patterns makes no sense, wrong locks or  violations of memory make no sense  because they are non-sensical.

But when experienced developers suggest new ideas on complex topics, like the separation between codecs and profiles, this is not "makes no sense". And it is also quite aggressive.

Jean-Baptiste Kempf -  President
+33 672 704 734

More information about the vlc-devel mailing list