[vlc-devel] [PATCH 1/4] aout: rename "stereo mode" to "output mode"

Rémi Denis-Courmont remi at remlab.net
Mon Apr 2 20:19:38 CEST 2018

Le 2 avril 2018 13:38:36 GMT+02:00, Jean-Baptiste Kempf <jb at videolan.org> a écrit :
>On Sat, 31 Mar 2018, at 08:24, Rémi Denis-Courmont wrote:
>> I did provide explanations what makes no sense and nobody explained
>> it  would. I also provided references to the rationale for why stuff
>> and needs to be like it is.
>And don't give me the "trac and commit log" argument.
>There are 10 of thousands of commits logs and trac comments.
>> I do not appreciate false accusations in public and IIRC, this is a 
>> violation of CoC. So plonk.
>It is clearly not a CoC violation to ask for explanations.
>So plonk also.
>Seriously, there is absolutely no technical or UX arguments from you on
>this patch, except vague stuff from the past.
>The patch is very reasonable, it just does a renaming of something that
>does already do more than stereo-mode (mono) and fulfills a very much
>requested feature, aka controlling the channels output, for a specific
>And this is a constant demand from our users, since we removed the
>fake-devices mode from the menus.
>If you don't give any good technical/UX argument, then this review is
>totally useless.
>Jean-Baptiste Kempf -  President
>+33 672 704 734
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:


You or any body else, especially the OP (namely Thomas in this case) can use git-blame or equivalent to get back at commit logs and from there to Trac tickets by number. They can do that as well as I.

In all likelihood, the variable name can even be searched in Trac (I have not checked).

So yes, I do give you that. Commit logd exist to be read. Trac descriptions and comments too. Trac and commit logs are valid documentation references, whether you like it or not, whether you can be bothered or not, and whether you have enough time or not. If you cannot, then you are welcome to not intervene in the review and save your time.
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.

More information about the vlc-devel mailing list